Implement get_key_value for HashMap, BTreeMap #49346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Diggsey
force-pushed
the
hashmap-get-pair
branch
from
e41b523 to
c3b1631
Compare
src/liballoc/btree/map.rs
Outdated
| @@ -576,6 +576,35 @@ impl<K: Ord, V> BTreeMap<K, V> { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns a references to the key-value pair corresponding to the supplied | |||
There was a problem hiding this comment.
Technically, it returns a pair which consists of references to the key and value - not sure if that's an important distinction, but we should remove " a " since it's not grammatically correct I think.
There was a problem hiding this comment.
Fixed - removed the part about references as that's included in the type signature anyway.
Diggsey
force-pushed
the
hashmap-get-pair
branch
3 times, most recently
from
799af44 to
1434e26
Compare
Mark-Simulacrum
requested changes
Mar 25, 2018
Diggsey
force-pushed
the
hashmap-get-pair
branch
from
1434e26 to
fbec3ec
Compare
|
Removed @bors r=Mark-Simulacrum |
|
@Diggsey: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r+ rollup |
|
📌 Commit fbec3ec has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 26, 2018
…mulacrum Implement get_key_value for HashMap, BTreeMap Fixes rust-lang#43143 Follow up from rust-lang#46992
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Mar 26, 2018
…mulacrum Implement get_key_value for HashMap, BTreeMap Fixes rust-lang#43143 Follow up from rust-lang#46992
bors
added a commit
that referenced
this pull request
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43143
Follow up from #46992